Page MenuHomePhabricator
Differential D1352

[qt] remove estimateSmartPriority from coincontroldialog
AbandonedPublic
Actions

Authored by schancel on May 2 2018, 02:21.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

As per title

Test Plan
make check

Run bitcoin-qt in regtest mode, goto preferences -> wallet, enable coin control. Go to the send coins tab, and click coin control. Ensure all the labels work as intended.

Diff Detail

Event Timeline

schancel created this revision.May 2 2018, 02:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 2 2018, 02:21
teamcity added a subscriber: teamcity.May 2 2018, 02:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel added a child revision: D1354: [mempool] remove use of deprecated estimateSmartPriority function.May 2 2018, 02:34
teamcity added a comment.May 2 2018, 02:41

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2450: Diff 3698.May 2 2018, 02:41
deadalnix added a subscriber: deadalnix.May 2 2018, 14:53

make check doesn't cover qt interface. This needs some manual testing.

deadalnix requested changes to this revision.May 2 2018, 15:31
This revision now requires changes to proceed.May 2 2018, 15:31
schancel edited the test plan for this revision. (Show Details)May 2 2018, 23:52
schancel added a comment.May 3 2018, 00:01

Seems to work just fine.

schancel edited the test plan for this revision. (Show Details)May 3 2018, 01:06
deadalnix accepted this revision.May 8 2018, 00:12
This revision is now accepted and ready to land.May 8 2018, 00:12
schancel abandoned this revision.May 9 2018, 23:27

This ended up superseded due to the way things landed.

schancel removed a child revision: D1354: [mempool] remove use of deprecated estimateSmartPriority function.May 9 2018, 23:27

Revision Contents
Changeset List

PathSize
src/
qt/
26 lines

Diff 3698

View Options

src/qt/coincontroldialog.cpp

Loading...