test: Use self.wait_until over wait_until_helper
ClosedPublic
Actions

Authored by sdulfari on Apr 1 2023, 04:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC41da7aa36f15: test: Use self.wait_until over wait_until_helper

Summary

wait_until_helper is a "private" helper, not intended to be used directly, because it doesn't scale the timeout with the timeout factor. Fix this by replacing it with a call to self.wait_until, which does the scaling.

Backport of core#27226

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Apr 1 2023, 04:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2023, 04:01

sdulfari requested review of this revision.Apr 1 2023, 04:01

teamcity edited the summary of this revision. (Show Details)Apr 1 2023, 04:01

Harbormaster completed remote builds in B22884: Diff 39118.Apr 1 2023, 04:17

Fabien accepted this revision.Apr 1 2023, 07:39

This revision is now accepted and ready to land.Apr 1 2023, 07:39

Closed by commit rABC41da7aa36f15: test: Use self.wait_until over wait_until_helper (authored by fanquake <fanquake@gmail.com>, committed by sdulfari). · Explain WhyApr 3 2023, 16:13

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC41da7aa36f15: test: Use self.wait_until over wait_until_helper.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

p2p.py

2 lines

Diff 39169

View Options

test/functional/test_framework/p2p.py

test: Use self.wait_until over wait_until_helperClosedPublicActions