Paths

Table of Contentst

Differential D13529

[Chronik] Add `Script` and `ScriptMut`
ClosedPublic
Actions

Authored by tobias_ruck on Apr 1 2023, 19:30.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8e93604814ca: [Chronik] Add `Script` and `ScriptMut`

Summary

We use two structs to represent Bitcoin scripts:

Script: An immutable and cheap to copy script.
ScriptMut: A mutable script with helpful functions to modify scripts.

Depends on D13528.

Test Plan

ninja check-crates

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-script

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22899
Build 45418: Build Diff	build-chronik
Build 45417: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 1 2023, 19:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2023, 19:30

tobias_ruck requested review of this revision.Apr 1 2023, 19:30

Harbormaster completed remote builds in B22889: Diff 39126.Apr 1 2023, 19:43

Fabien requested changes to this revision.Apr 3 2023, 09:22

Fabien added inline comments.

chronik/bitcoinsuite-core/src/script/script.rs
108 ↗	(On Diff #39126)	67, or `1 + UncompressedPubKey::SIZE + 1` if you feel like being verbose (then do the same for compressed key)
chronik/bitcoinsuite-core/src/script/script_mut.rs
43 ↗	(On Diff #39126)	unnecessary copy/pasta

This revision now requires changes to proceed.Apr 3 2023, 09:22

Fix script capacities, remove some dead code

Fabien accepted this revision.Apr 3 2023, 10:20

This revision is now accepted and ready to land.Apr 3 2023, 10:20

Harbormaster completed remote builds in B22899: Diff 39141.Apr 3 2023, 10:36

tobias_ruck added a child revision: D13530: [Chronik] Add `OP_RETURN` opcode and `Script::is_opreturn`.Apr 3 2023, 10:55

Closed by commit rABC8e93604814ca: [Chronik] Add `Script` and `ScriptMut` (authored by tobias_ruck). · Explain WhyApr 3 2023, 10:57

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC8e93604814ca: [Chronik] Add `Script` and `ScriptMut`.

tobias_ruck mentioned this in D13536: [Chronik] Fix script capacities in script.rs & dead code in script_mut.rs (again).Apr 3 2023, 12:15

tobias_ruck mentioned this in rABC9e6ac7b24e41: [Chronik] Fix script capacities in script.rs & dead code in script_mut.rs….Apr 3 2023, 12:37

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path

Size

chronik/

bitcoinsuite-core/

src/

script/

script.rs

143 lines

script_mut.rs

62 lines

Diff 39141

View Options

chronik/bitcoinsuite-core/src/script/script.rs