[flynt] remove buggy --transform-concats option
ClosedPublic
Actions

Authored by PiRK on Apr 5 2023, 07:53.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC26b68cf7441f: [flynt] remove buggy --transform-concats option

Summary

See https://github.com/ikamensh/flynt/issues/173

The linter will still be able to convert "%"-formatted strings and "{}".format( occurences to f-strings.
It will no longer simplify string concatenations.

Test Plan

Touch test_runner.py and make sure arc lint does not clear the file.

Add actual lines that flynt will update, and check that the changes from arc lint is as expected. E.g:

diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
index 38ac427eeb..079079e3bb 100755
--- a/test/functional/test_runner.py
+++ b/test/functional/test_runner.py
@@ -163,6 +163,9 @@ class TestCase:
         self.test_num = test_num
         self.failfast_event = failfast_event
         self.flags = flags
+        a = "%s " % "toto"
+        b = "{}".format(a)
+        print(a + b)

     def run(self):
         if self.failfast_event.is_set():