Adding the base files for the new ecash site build
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC1d42191497ad: Add base next.js files for ecash site
run the site with npm run dev and see if it works
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- add-ecash-website
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23060 Build 45740: Build Diff Build 45739: arc lint + arc unit
Event Timeline
- Directory should be named web/ecash-home, not just web/ecash
- What version of node did you use to build / render?
- Was this generated by running some kind of npx command or using a template? If so please comment in the summary.
web/ecash/.gitignore | ||
---|---|---|
1–28 ↗ | (On Diff #39314) | Is this from some kind of template? |
web/ecash/README.md | ||
3 ↗ | (On Diff #39314) | delete informational |
web/ecash/package.json | ||
1–13 ↗ | (On Diff #39314) | Was this file generated with an npx command? Is it from some kind of a template? |
2 ↗ | (On Diff #39314) | let's keep the package name the same as its directory name. Say, ecash-home |
web/ecash/pages/index.js | ||
4 ↗ | (On Diff #39314) | Will all styles be inline like this going forward? If this is going to change or be immediately steamrolled, can just exclude any styling. If this was generated by an npx command or some kind of a template, please explain in the diff summary |
web/ecash/public/images/ecash-logo.svg | ||
2 ↗ | (On Diff #39314) | add newline at end of file |
web/ecash/styles/global.css | ||
1–44 ↗ | (On Diff #39314) | Is this file generated? |
web/ecash/styles/normalize.css | ||
1 ↗ | (On Diff #39314) | where did this file come from? what is it doing? |
To address some of the questions
- I used npx create-next-app to get started
- Im on node v16.14.2
the package.json was generated by create next app
I removed normalize.css as dont need at this point
I added the global.css rules
Could you summarize the changes between what npx create-next-app generates and what is in this diff?
the package.json was generated by create next app
I removed normalize.css as dont need at this point
I added the global.css rules
i.e. are these the only changes?
Im on node v16.14.2
Ok great. This is consistent with what we have in CONTRIBUTING.md. I've created a task to look into standardizing the node version across the monorepo with a .nvmrc file. Beyond the scope of this diff but worth noting.
For sure, you can see the create next app boiler plate I used here https://github.com/vercel/next-learn/tree/master/basics/learn-starter
But my changes were
- add the font files and the css for the fonts and some basic body style
- add a video directory
- change readme
- remove the content and styles that come with the boiler plate
- added ecash logo and favicon
- the previous git ignore I had actually did come with the create next app, but I trimmed it to only what is needed