Page MenuHomePhabricator
Differential D13600

contrib: use LIEF for security checks
ClosedPublic
Actions

Authored by PiRK on Apr 6 2023, 13:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5d98b64ae1fd: contrib: use LIEF for security checks
Summary

Also add PE PIE check to security checks

This is a partial backport of core#21664
https://github.com/bitcoin/bitcoin/pull/21664/commits/465967b5ef4b4f02e9d6783a94eca012d4ebcdab
https://github.com/bitcoin/bitcoin/pull/21664/commits/7e7eae7aa86ab95c44eed601f8c993285a256bbc
https://github.com/bitcoin/bitcoin/pull/21664/commits/a25b2e965c93fe2a46a2f8f1e7bdf5642d453511
https://github.com/bitcoin/bitcoin/pull/21664/commits/0f5d77c8e4db691733edb455dd9e31dabe933b8d
https://github.com/bitcoin/bitcoin/pull/21664/commits/955140b3265d3bcb9504c61d73fbfdadfff8a2b2

Test Plan

gitian builds

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 6 2023, 13:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2023, 13:57
teamcity edited the summary of this revision. (Show Details)Apr 6 2023, 13:57
PiRK added a comment.Apr 6 2023, 13:59

@bot gitian-linux gitian-osx gitian-win

teamcity awarded a token.Apr 6 2023, 13:59
PiRK updated this revision to Diff 39347.Apr 6 2023, 14:12
PiRK edited the summary of this revision. (Show Details)

squash with the other relevant commit deduplication the functions

Harbormaster completed remote builds in B23036: Diff 39346.Apr 6 2023, 14:12
PiRK mentioned this in D13601: contrib: use LIEF symbol-check.Apr 6 2023, 14:17
Harbormaster completed remote builds in B23037: Diff 39347.Apr 6 2023, 14:30
PiRK published this revision for review.Apr 6 2023, 14:34
Fabien requested changes to this revision.Apr 6 2023, 14:54
Fabien added a subscriber: Fabien.

you need to also install the package on CI

This revision now requires changes to proceed.Apr 6 2023, 14:54
PiRK updated this revision to Diff 39353.Apr 6 2023, 15:11

install lief on CI and docker image

Harbormaster completed remote builds in B23041: Diff 39353.Apr 6 2023, 15:49
Fabien accepted this revision.Apr 6 2023, 16:20
This revision is now accepted and ready to land.Apr 6 2023, 16:20
Closed by commit rABC5d98b64ae1fd: contrib: use LIEF for security checks (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyApr 6 2023, 17:27
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5d98b64ae1fd: contrib: use LIEF for security checks.
PiRK mentioned this in rABC0b3931605c0d: contrib: use LIEF symbol-check.

Revision Contents
Changeset List

PathSize
cmake/
modules/
1 line
contrib/
devtools/
123 lines
gitian-descriptors/
3 lines
3 lines
3 lines
utils/
2 lines

Diff 39360

View Options

cmake/modules/BinaryTest.cmake

Loading...
View Options

contrib/devtools/security-check.py

Loading...
View Options

contrib/gitian-descriptors/gitian-linux.yml

Loading...
View Options

contrib/gitian-descriptors/gitian-osx.yml

Loading...
View Options

contrib/gitian-descriptors/gitian-win.yml

Loading...
View Options

contrib/utils/install-dependencies-bullseye.sh

Loading...