Differential D13658

[avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools
ClosedPublic
Actions

Authored by sdulfari on Apr 11 2023, 05:30.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC64e1de95c29b: [avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools

Summary

This function has been copy-pasted around a few times without major modifications.
There are improvements we can make to it, so it is best to do it in one place.

Test Plan

ninja && ./test/functional/test_runner.py abc_p2p_avalanche_* abc_rpc_isfinal

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Apr 11 2023, 05:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2023, 05:30

sdulfari requested review of this revision.Apr 11 2023, 05:30

Harbormaster completed remote builds in B23187: Diff 39525.Apr 11 2023, 05:48

Thanks, I was willing to do that + a rename because the actual name is pretty bad (not only it finds the poll but also proceed with a vote). Could you please handle that rename as well ?

This revision is now accepted and ready to land.Apr 11 2023, 06:04

Yes, changes to come. I'll think up a better name.

Closed by commit rABC64e1de95c29b: [avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools (authored by sdulfari). · Explain WhyApr 11 2023, 06:21

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC64e1de95c29b: [avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools.