Page MenuHomePhabricator

[avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools
ClosedPublic

Authored by sdulfari on Apr 11 2023, 05:30.

Details

Summary

This function has been copy-pasted around a few times without major modifications.
There are improvements we can make to it, so it is best to do it in one place.

Test Plan
ninja && ./test/functional/test_runner.py abc_p2p_avalanche_* abc_rpc_isfinal

Diff Detail

Repository
rABC Bitcoin ABC
Branch
find-inv-in-poll
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23187
Build 45993: Build Diffbuild-clang-tidy · build-without-wallet · build-debug · build-clang · build-diff
Build 45992: arc lint + arc unit

Event Timeline

Fabien added a subscriber: Fabien.

Thanks, I was willing to do that + a rename because the actual name is pretty bad (not only it finds the poll but also proceed with a vote). Could you please handle that rename as well ?

This revision is now accepted and ready to land.Apr 11 2023, 06:04

Yes, changes to come. I'll think up a better name.