Differential D13660

[avalanche] Rename variables shadowing builtins in avatools
ClosedPublic
Actions

Authored by sdulfari on Apr 11 2023, 06:56.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC72a3ee627ac7: [avalanche] Rename variables shadowing builtins in avatools

Summary

Shadowing builtins can lead to unexpected behavior. This is one of many steps to integrating flake8-builtins so we do not have to worry about this in the future.

Test Plan

./test/functional/test_runner.py abc_*
pip3 install flake8-builtins
flake8 test/functional/test_framework/avatools.py  # verify no A00x errors

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Apr 11 2023, 06:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2023, 06:56

sdulfari requested review of this revision.Apr 11 2023, 06:56

PiRK accepted this revision.Apr 11 2023, 07:07

This revision is now accepted and ready to land.Apr 11 2023, 07:07

Harbormaster completed remote builds in B23189: Diff 39529.Apr 11 2023, 07:27

Closed by commit rABC72a3ee627ac7: [avalanche] Rename variables shadowing builtins in avatools (authored by sdulfari). · Explain WhyApr 11 2023, 16:12

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC72a3ee627ac7: [avalanche] Rename variables shadowing builtins in avatools.

sdulfari mentioned this in D13675: Fix shadowing of python builtins in tests.Apr 11 2023, 18:03

sdulfari mentioned this in rABCe88798b0f81e: Fix shadowing of python builtins in tests.Apr 11 2023, 18:37

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_voting.py

2 lines

test_framework/

avatools.py

12 lines

Diff 39553

View Options

test/functional/abc_p2p_avalanche_voting.py