Differential D13675

Fix shadowing of python builtins in tests
ClosedPublic
Actions

Authored by sdulfari on Apr 11 2023, 18:03.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe88798b0f81e: Fix shadowing of python builtins in tests

Summary

Shadowing builtins can lead to unexpected behavior. Continuing work from D13660

Test Plan

ninja check-functional check-buildbot

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Apr 11 2023, 18:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2023, 18:03

sdulfari requested review of this revision.Apr 11 2023, 18:03

PiRK accepted this revision.Apr 11 2023, 18:21

This revision is now accepted and ready to land.Apr 11 2023, 18:21

Harbormaster completed remote builds in B23210: Diff 39561.Apr 11 2023, 18:28

Closed by commit rABCe88798b0f81e: Fix shadowing of python builtins in tests (authored by sdulfari). · Explain WhyApr 11 2023, 18:37

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABCe88798b0f81e: Fix shadowing of python builtins in tests.

sdulfari mentioned this in D13740: [lint] Require flake8-builtins to ensure we do not add shadowing of python builtins.Apr 19 2023, 17:51

sdulfari mentioned this in rABCb608021456ee: [lint] Require flake8-builtins to ensure we do not add shadowing of python….Apr 19 2023, 20:04

Revision Contents
Changeset List

Path

Size

cmake/

utils/

junit-reports-merge.py

2 lines

contrib/

buildbot/

test/

test_phabricator.py

6 lines

test/

functional/

feature_addrman.py

4 lines

feature_csv_activation.py

4 lines

interface_bitcoin_cli.py

8 lines

rpc_getblockfrompeer.py

4 lines

test_framework/

address.py

12 lines

messages.py

8 lines

test_node.py

4 lines

Diff 39564

View Options

cmake/utils/junit-reports-merge.py

View Options

contrib/buildbot/test/test_phabricator.py

View Options

test/functional/feature_addrman.py

View Options

test/functional/feature_csv_activation.py

View Options

test/functional/interface_bitcoin_cli.py

View Options

test/functional/rpc_getblockfrompeer.py

View Options

test/functional/test_framework/address.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/test_node.py

Fix shadowing of python builtins in testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39564

cmake/utils/junit-reports-merge.py

contrib/buildbot/test/test_phabricator.py

test/functional/feature_addrman.py

test/functional/feature_csv_activation.py

test/functional/interface_bitcoin_cli.py

test/functional/rpc_getblockfrompeer.py

test/functional/test_framework/address.py

test/functional/test_framework/messages.py

test/functional/test_framework/test_node.py

Fix shadowing of python builtins in tests
ClosedPublic
Actions

Revision Contents
Changeset List