This will make UI changes easier to review. This spins a temporarly yet fully featured cashtab instance.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC4f9711e3de56: [CI] Add support for cashtab preview
./contrib/teamcity/build-configurations.py preview-cashtab
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.89.41.69:41734 for the next 60 minutes.
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.68.37.192:41058 for the next 60 minutes.
Comment Actions
Using brave
- link works
- app seems fine
- clicking the QR code shows the "copied to clipboard" notification, however nothing is copied to clipboard
cashtab.com in brave is not showing the same issue
Comment Actions
working theory: this behavior is related to preview link not being https
this would also impact some of Cashtab's API calls
Comment Actions
While doable, using https for the previews is not very convenient as it requires all the Teamcity build agents need to have a DNS A field attached and maintained, plus the overhead of serving https.
It's likely not worth it for the preview feature, and shouldn't be handled in this diff anyway.
Comment Actions
will help for CSS changes. Cashtab reviewers need to be aware of some expected functionality limitations.