Paths

Table of Contentst

Differential D13727

[chronik mock] Make sure history function is async so Promise.all() tests work
ClosedPublic
Actions

Authored by bytesofman on Apr 14 2023, 22:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2e1d16d2fa47: [chronik mock] Make sure history function is async so Promise.all() tests work

Summary

Discovered this bug in creating D13707

The chronik function to get one page of tx history is async. For efficiency, getting multiple pages is usually done with Promise.all(). This will only work on an array of promises, which need to be async functions.

Test Plan

See passing unit tests in D13707
Check unit tests for alias-server and ecash-herald here

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Apr 14 2023, 22:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2023, 22:40

bytesofman requested review of this revision.Apr 14 2023, 22:40

Harbormaster completed remote builds in B23331: Diff 39765.Apr 14 2023, 22:42

Fabien accepted this revision.Apr 15 2023, 06:30

This revision is now accepted and ready to land.Apr 15 2023, 06:30

Closed by commit rABC2e1d16d2fa47: [chronik mock] Make sure history function is async so Promise.all() tests work (authored by bytesofman). · Explain WhyApr 19 2023, 20:55

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC2e1d16d2fa47: [chronik mock] Make sure history function is async so Promise.all() tests work.

Revision Contents
Changeset List

Path

Size

apps/

alias-server/

test/

mocks/

chronikMock.js

2 lines

ecash-herald/

test/

mocks/

chronikMock.js

2 lines

Diff 39828

View Options

apps/alias-server/test/mocks/chronikMock.js