Differential D13741

[lint] Fix variables shadowing python builtins in rpc_generateblock.py
ClosedPublic
Actions

Authored by sdulfari on Apr 19 2023, 18:00.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC0146b16d7e40: [lint] Fix variables shadowing python builtins in rpc_generateblock.py

Summary

Shadowing builtins can lead to unexpected behavior. Continuing work from D13740

Test Plan

./test/functional/test_runner.py rpc_generateblock
flake8 rpc_generateblock.py | grep A001  # empty

Diff Detail

Repository

rABC Bitcoin ABC

Branch

a001-rpc-generateblock

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23371
Build 46361: Build Diff	build-without-wallet · build-clang-tidy · build-debug · build-diff · build-clang
Build 46360: arc lint + arc unit

Event Timeline

sdulfari created this revision.Apr 19 2023, 18:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2023, 18:00

sdulfari requested review of this revision.Apr 19 2023, 18:00

Harbormaster completed remote builds in B23371: Diff 39812.Apr 19 2023, 18:15

PiRK accepted this revision.Apr 19 2023, 19:15

This revision is now accepted and ready to land.Apr 19 2023, 19:15

Closed by commit rABC0146b16d7e40: [lint] Fix variables shadowing python builtins in rpc_generateblock.py (authored by sdulfari). · Explain WhyApr 19 2023, 20:17

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC0146b16d7e40: [lint] Fix variables shadowing python builtins in rpc_generateblock.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_generateblock.py

24 lines

Diff 39812

View Options

test/functional/rpc_generateblock.py

[lint] Fix variables shadowing python builtins in rpc_generateblock.pyClosedPublicActions