Differential D13745

[lint] Fix variables shadowing python builtins in interface_zmq.py
ClosedPublic
Actions

Authored by sdulfari on Apr 19 2023, 18:40.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC441aaa28db9b: [lint] Fix variables shadowing python builtins in interface_zmq.py

Summary

Shadowing builtins can lead to unexpected behavior. Continuing work from D13740

Test Plan

./test/functional/test_runner.py interface_zmq
flake8 interface_zmq.py | grep A001  # empty

Diff Detail

Repository

rABC Bitcoin ABC

Branch

a001-interface-zmq

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23376
Build 46371: Build Diff	build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 46370: arc lint + arc unit

Event Timeline

sdulfari created this revision.Apr 19 2023, 18:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2023, 18:40

sdulfari requested review of this revision.Apr 19 2023, 18:40

Harbormaster completed remote builds in B23376: Diff 39817.Apr 19 2023, 18:58

PiRK accepted this revision.Apr 19 2023, 19:36

This revision is now accepted and ready to land.Apr 19 2023, 19:36

Closed by commit rABC441aaa28db9b: [lint] Fix variables shadowing python builtins in interface_zmq.py (authored by sdulfari). · Explain WhyApr 19 2023, 20:17

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC441aaa28db9b: [lint] Fix variables shadowing python builtins in interface_zmq.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

interface_zmq.py

18 lines

Diff 39817

View Options

test/functional/interface_zmq.py

[lint] Fix variables shadowing python builtins in interface_zmq.pyClosedPublicActions