Differential D13747

[lint] Fix variables shadowing python builtins in gen-ninja-deps.py
ClosedPublic
Actions

Authored by sdulfari on Apr 19 2023, 20:02.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC6ecf7d65e2b9: [lint] Fix variables shadowing python builtins in gen-ninja-deps.py

Summary

Shadowing builtins can lead to unexpected behavior. Continuing work from D13740

Test Plan

ninja generate_univalue_escapes_h
flake8 cmake/utils/gen-ninja-deps.py  # empty

Diff Detail

Repository

rABC Bitcoin ABC

Branch

a001-gen-ninja-deps

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23378
Build 46375: Build Diff	build-without-wallet · build-debug · build-clang · build-diff · build-clang-tidy
Build 46374: arc lint + arc unit

Event Timeline

sdulfari created this revision.Apr 19 2023, 20:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2023, 20:02

sdulfari requested review of this revision.Apr 19 2023, 20:02

Harbormaster completed remote builds in B23378: Diff 39819.Apr 19 2023, 20:15

PiRK accepted this revision.Apr 20 2023, 06:11

This revision is now accepted and ready to land.Apr 20 2023, 06:11

Closed by commit rABC6ecf7d65e2b9: [lint] Fix variables shadowing python builtins in gen-ninja-deps.py (authored by sdulfari). · Explain WhyApr 20 2023, 15:49

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC6ecf7d65e2b9: [lint] Fix variables shadowing python builtins in gen-ninja-deps.py.

Revision Contents
Changeset List

Path

Size

cmake/

utils/

gen-ninja-deps.py

6 lines

Diff 39819

View Options

cmake/utils/gen-ninja-deps.py

[lint] Fix variables shadowing python builtins in gen-ninja-deps.pyClosedPublicActions