Differential D13750

[lint] Fix variables shadowing python builtins in zmq_sub.py
ClosedPublic
Actions

Authored by sdulfari on Apr 20 2023, 18:59.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd7e213a04261: [lint] Fix variables shadowing python builtins in zmq_sub.py

Summary

Shadowing builtins can lead to unexpected behavior. Continuing work from D13740

Test Plan

ninja bitcoind
./src/bitcoind -testnet -zmqpubsequence=tcp://127.0.0.1:28332
../contrib/zmq/zmq_sub.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Apr 20 2023, 18:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2023, 18:59

sdulfari requested review of this revision.Apr 20 2023, 18:59

Harbormaster completed remote builds in B23388: Diff 39839.Apr 20 2023, 18:59

sdulfari added a child revision: D13751: [lint] Fix remaining variables shadowing python builtins and enable detection of shadowed variables going forward.Apr 20 2023, 19:52

PiRK accepted this revision.Apr 21 2023, 06:32

This revision is now accepted and ready to land.Apr 21 2023, 06:32

Closed by commit rABCd7e213a04261: [lint] Fix variables shadowing python builtins in zmq_sub.py (authored by sdulfari). · Explain WhyApr 21 2023, 15:30

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABCd7e213a04261: [lint] Fix variables shadowing python builtins in zmq_sub.py.

Revision Contents
Changeset List

Path

Size

contrib/

zmq/

4 lines

Diff 39856

contrib/zmq/zmq_sub.py

Loading...