Adding some functionality to control background video playback speed based on theme specification.
I went for 0 for the stealth theme as I thought it looked better/more stealthy than a slowed down version, but open to other thoughts here
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC8841ff3a40d4: [e.cash] Stealth theme video speed
npm run dev
Switch themes with the bottom right switch, the background video should stop playing in stealth theme. It should resume when theme is switched back
Adjust the videospeed value in the theme to differnt numbers. See if it still works and if you find any values more appealing
@bot preview-e.cash
See if it builds and runs correctly
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.60:41133 for the next 60 minutes.
| web/e.cash/components/videobackground/index.js | ||
|---|---|---|
| 6–15 ↗ | (On Diff #40128) | ^ above recommended change looks confusing. suggestion is to replace existing code with const themeContext = useContext(ThemeContext);
const videoRef = useRef();
useEffect(() => {
videoRef.current.playbackRate = themeContext.filters.videospeed;
}, [themeContext.filters.videospeed]);i.e. remove the setSpeed function kinda ridiculous that this is how it needs to be done in React but I couldn't find any way to just set playbackRate directly on the <video> component in react. |
| web/e.cash/styles/theme.js | ||
| 35 ↗ | (On Diff #40128) | while 0 is probably the coolest param for toggling between the two themes, when this is launched that won't be how the user experiences the page. 0.4 seems to have the right gravitas |