Page MenuHomePhabricator

simplify detection of OpenSSL version
AbandonedPublic

Authored by PiRK on May 3 2023, 10:02.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

The check OPENSSL_VERSION_NUMBER >= 0x10100000L works for every version including the most recent, while the HAVE_DECL_EVP_MD_CTX_NEW does not work for openssl 1.1.1 when cross compiling for an unknown reason (see D13681)

The reason the OPENSSL_VERSION_NUMBER >= 0x10100000L check was changed was to support LibreSSL (see core#9475). I'm not aware of anyone building Bitcoin ABC with LibreSSL

Test Plan

ninja all check-all

various CI builds

Event Timeline

@bot build-win64 build-linux64 build-osx gitian-win gitian-osx gitian-linux

PiRK published this revision for review.May 3 2023, 10:55