Chaging how the global styles are applied to be more consistent with styled components
-utilized styled components createGlobalStyle feature and added to the top of _app.js
-this should inject the previous css rules globally
-I moved the "container" class to be a component instead to avoid the inconsistent single classname used for that
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC99b499770788: [e.cash] Refactor global css
@bot preview-e.cash
See if everything renders as before
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-global-styles
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23650 Build 46914: Build Diff Build 46913: arc lint + arc unit
Event Timeline
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41798 for the next 60 minutes.
web/e.cash/components/container/index.js | ||
---|---|---|
3 ↗ | (On Diff #40223) | Seems a bit overkill for this to have its own file. We might have a need for many simple components that are style only and do not require props or other react logic. Also this is not consistently applied. Container gets its own folder and index.js, but layout.js is just a file in the components directory? Also other components with a directory have an index.js which defines the component logic and a styles.js which defines styled components, but here we have index.js defining the styled component.
Then in the future, on a given webpage, you can just import {Container, Spacer, HorizontalLine, ... etc, other simple styled components} from 'components/atoms' |
web/e.cash/pages/_app.js | ||
6 ↗ | (On Diff #40223) | This should be in the new atoms folder |
@bot preview-e.cash
web/e.cash/components/atoms/index.js | ||
---|---|---|
3–4 ↗ | (On Diff #40225) | combine into one object |
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41864 for the next 60 minutes.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41853 for the next 60 minutes.