Page MenuHomePhabricator
Differential D13919

[e.cash] Add page content for wealth redefined
ClosedPublic
Actions

Authored by johnkuney on May 22 2023, 16:27.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC0995f2c68c71: [e.cash] Add page content for wealth redefined
Summary

Adding the content for the wealth redfined page. Added text blocks and images and the quote carousel

Test Plan

@bot preview-e.cash
navigate to the wealth redfined page and check everything looks good on mobile and desktop and both themes

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-wealth-redefined-content
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23764
Build 47138: Build Diff
Build 47137: arc lint + arc unit

Event Timeline

johnkuney created this revision.May 22 2023, 16:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2023, 16:27
johnkuney requested review of this revision.May 22 2023, 16:27
Harbormaster completed remote builds in B23755: Diff 40376.May 22 2023, 16:28
johnkuney updated this revision to Diff 40378.May 22 2023, 19:46

remove comments

Harbormaster completed remote builds in B23757: Diff 40378.May 22 2023, 19:46
bytesofman added a subscriber: bytesofman.May 23 2023, 16:15

@bot preview-e.cash

teamcity awarded a token.May 23 2023, 16:15

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41018 for the next 60 minutes.

bytesofman requested changes to this revision.May 23 2023, 16:22
bytesofman added inline comments.
web/e.cash/components/quote-carousel/index.js
43 ↗(On Diff #40378)

this is the same as saying active={index === activeIndex}

55 ↗(On Diff #40378)

ditto

This revision now requires changes to proceed.May 23 2023, 16:22
johnkuney updated this revision to Diff 40386.May 23 2023, 17:02

better logic syntax, mobile quote carousel style

Harbormaster completed remote builds in B23764: Diff 40386.May 23 2023, 17:02
bytesofman added a comment.May 23 2023, 17:03

@bot preview-e.cash

teamcity updated a token.May 23 2023, 17:03

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41110 for the next 60 minutes.

bytesofman accepted this revision.May 23 2023, 17:05
This revision is now accepted and ready to land.May 23 2023, 17:05
Closed by commit rABC0995f2c68c71: [e.cash] Add page content for wealth redefined (authored by johnkuney). · Explain WhyMay 23 2023, 17:50
This revision was automatically updated to reflect the committed changes.
johnkuney added a commit: rABC0995f2c68c71: [e.cash] Add page content for wealth redefined.

Revision Contents
Changeset List

PathSize
web/
e.cash/
components/
atoms/
4 lines
28 lines
h3/
10 lines
15 lines
quote-carousel/
60 lines
97 lines
pages/
78 lines
public/
images/
styles/
4 lines
pages/
11 lines
2 lines

Diff 40386

View Options

web/e.cash/components/atoms/index.js

Loading...
View Options

web/e.cash/components/atoms/styles.js

Loading...
View Options

web/e.cash/components/h3/index.js

Loading...
View Options

web/e.cash/components/h3/styles.js

Loading...
View Options

web/e.cash/components/quote-carousel/index.js

Loading...
View Options

web/e.cash/components/quote-carousel/styles.js

Loading...
View Options

web/e.cash/pages/wealth-redefined.js

Loading...
View Options

web/e.cash/public/images/bitcoinabc-logo.png

Loading...
View Options

web/e.cash/public/images/hands-logo.png

Loading...
View Options

web/e.cash/public/images/rocket.png

Loading...
View Options

web/e.cash/styles/global.js

Loading...
View Options

web/e.cash/styles/pages/wealth-redefined.js

Loading...
View Options

web/e.cash/styles/theme.js

Loading...