Page MenuHomePhabricator

[e.cash] Add start of brand page
ClosedPublic

Authored by johnkuney on May 24 2023, 15:12.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC691f7f0c5d0c: [e.cash] Add start of brand page
Summary

adding first half of brand page. Will add the logo links in another diff

Test Plan

preview the site and navigate to the ecash brand page
Check everything looks good on mobile and both themes

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-brand-page
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningweb/e.cash/public/animations/robot-hand.json:80SPELL2Possible Spelling Mistake
Unit
No Test Coverage
Build Status
Buildable 23780
Build 47170: Build Diff
Build 47169: arc lint + arc unit

Event Timeline

web/e.cash/components/sub-page-hero/index.js
11

also optional?

any optional params need to go last. if imagespeed and imagereverse are the only optional params, they should be last.

bytesofman added inline comments.
web/e.cash/components/sub-page-hero/index.js
11

nm doesn't matter for object input

This revision is now accepted and ready to land.May 24 2023, 17:26
This revision was landed with ongoing or failed builds.May 24 2023, 19:05
This revision was automatically updated to reflect the committed changes.