Page MenuHomePhabricator
Differential D13928

[e.cash] Add start of brand page
ClosedPublic
Actions

Authored by johnkuney on May 24 2023, 15:12.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC691f7f0c5d0c: [e.cash] Add start of brand page
Summary

adding first half of brand page. Will add the logo links in another diff

Test Plan

preview the site and navigate to the ecash brand page
Check everything looks good on mobile and both themes

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-brand-page
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningweb/e.cash/public/animations/robot-hand.json:80SPELL2Possible Spelling Mistake
Unit
No Test Coverage
Build Status
Buildable 23780
Build 47170: Build Diff
Build 47169: arc lint + arc unit

Event Timeline

johnkuney created this revision.May 24 2023, 15:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2023, 15:12
johnkuney requested review of this revision.May 24 2023, 15:12
Harbormaster completed remote builds in B23780: Diff 40407.May 24 2023, 15:12
bytesofman added a subscriber: bytesofman.May 24 2023, 17:12

@bot preview-e.cash

teamcity awarded a token.May 24 2023, 17:12

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41789 for the next 60 minutes.

bytesofman added inline comments.May 24 2023, 17:15
web/e.cash/components/sub-page-hero/index.js
11

also optional?

any optional params need to go last. if imagespeed and imagereverse are the only optional params, they should be last.

bytesofman accepted this revision.May 24 2023, 17:26
bytesofman added inline comments.
web/e.cash/components/sub-page-hero/index.js
11

nm doesn't matter for object input

This revision is now accepted and ready to land.May 24 2023, 17:26
This revision was landed with ongoing or failed builds.May 24 2023, 19:05
Closed by commit rABC691f7f0c5d0c: [e.cash] Add start of brand page (authored by johnkuney). · Explain Why
This revision was automatically updated to reflect the committed changes.
johnkuney added a commit: rABC691f7f0c5d0c: [e.cash] Add start of brand page.

Revision Contents
Changeset List

PathSize
web/
e.cash/
components/
sub-page-hero/
7 lines
data/
5 lines
pages/
76 lines
public/
animations/
images/
1 line
2 lines
1 line
styles/
pages/
11 lines

Diff 40407

View Options

web/e.cash/components/sub-page-hero/index.js

Loading...
View Options

web/e.cash/data/navitems.js

Loading...
View Options

web/e.cash/pages/ecash-brand.js

Loading...
View Options

web/e.cash/public/animations/robot-hand.json

Loading...
View Options

web/e.cash/public/images/logo-diagram-2.svg

Loading...
View Options

web/e.cash/public/images/logo-diagram-3.svg

Loading...
View Options

web/e.cash/public/images/logo-diagram.svg

Loading...
View Options

web/e.cash/styles/pages/ecash-brand.js

Loading...