[e.cash] Add faq page
ClosedPublic
Actions

Authored by johnkuney on May 25 2023, 15:51.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCfcb9c9452298: [e.cash] Add faq page

Summary

Adding the faq page. Created list of faqs and rendering them on the page. Note: made a style tweak to the H2 component
as the long title revealed a flaw

Test Plan

preview the site and navigate to the faq page
check everything looks good on both themes and all screen sizes
check content for any mistakes

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-faq

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	web/e.cash/public/animations/faq.json:23	SPELL2	Possible Spelling Mistake
Warning	web/e.cash/public/animations/faq.json:143	SPELL2	Possible Spelling Mistake
Warning	web/e.cash/public/animations/faq.json:239	SPELL2	Possible Spelling Mistake
Warning	web/e.cash/public/animations/faq.json:359	SPELL2	Possible Spelling Mistake

Unit

No Test Coverage

Build Status

Buildable 23801
Build 47212: Build Diff
Build 47211: arc lint + arc unit

Event Timeline

johnkuney created this revision.May 25 2023, 15:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2023, 15:51

johnkuney requested review of this revision.May 25 2023, 15:51

Harbormaster completed remote builds in B23798: Diff 40434.May 25 2023, 15:51

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.60:41009 for the next 60 minutes.

bytesofman requested changes to this revision.May 25 2023, 15:59

bytesofman added inline comments.

web/e.cash/pages/faq.js

37 ↗

(On Diff #40434)

do we need to use dangerouslySetInnerHTML here?

Why not define the answer as a react component instead of a string? This would also allow us to use our custom link component instead of having to manually code links to open in a new tab.

for example, instead of

{
        question:
            'Where can I find eCash price information compared to other cryptocurrencies?',
        answer: '<p>eCash price information is available at all leading crypto research sources, like <a href="https://www.coingecko.com/en/coins/ecash" target="_blank">Coingecko</a>, <a href="https://coinmarketcap.com/currencies/ecash/" target="_blank">Coinmarketcap</a>, and <a href="https://crypto.com/price/ecash?utm_medium=widget&amp;utm_campaign=CoinTickerClassic&amp;utm_source=crypto.com&amp;utm_id=ecash" target="_blank">Crypto.com</a></p>',
    },

{
        question:
            'Where can I find eCash price information compared to other cryptocurrencies?',
        answer: <><p>eCash price information is available at all leading crypto research sources, like <CustomLink href="https://www.coingecko.com/en/coins/ecash">Coingecko</CustomLink>, <CustomLink href="https://coinmarketcap.com/currencies/ecash/">Coinmarketcap</CustomLink>, and <CustomLink href="https://crypto.com/price/ecash?utm_medium=widget&amp;utm_campaign=CoinTickerClassic&amp;utm_source=crypto.com&amp;utm_id=ecash">Crypto.com</CustomLink></p></>,
    },

Then