Paths

Table of Contentst

Differential D13968

replace.hpp dependency
ClosedPublic
Actions

Authored by PiRK on Jun 2 2023, 06:27.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc682e1d7f65b: refactor: Drop boost/algorithm/string/replace.hpp dependency

Summary

test: Add test case for ReplaceAll() function

refactor: Drop boost/algorithm/string/replace.hpp dependency

This is a backport of core#25803
with a std::move removed change (see comment by MarcoFalke https://github.com/bitcoin/bitcoin/pull/25803/commits/fea75ad3caa29972db32d3ce7e0fe125ec77a0eb#r946498588)

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 2 2023, 06:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2023, 06:27

teamcity edited the summary of this revision. (Show Details)Jun 2 2023, 06:27

@bot build-linux64 build-native-osx

teamcity awarded a token.Jun 2 2023, 06:28

Harbormaster completed remote builds in B23869: Diff 40541.Jun 2 2023, 06:49

PiRK published this revision for review.Jun 2 2023, 09:02

Fabien accepted this revision.Jun 2 2023, 13:34

This revision is now accepted and ready to land.Jun 2 2023, 13:34

Closed by commit rABCc682e1d7f65b: refactor: Drop boost/algorithm/string/replace.hpp dependency (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyJun 3 2023, 08:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc682e1d7f65b: refactor: Drop boost/algorithm/string/replace.hpp dependency.

Revision Contents
Changeset List

Path

Size

src/

test/

util_tests.cpp

17 lines

util/

string.h

4 lines

string.cpp

12 lines

test/

lint/

lint-boost-dependencies.sh

1 line

Diff 40565

View Options

src/test/util_tests.cpp

View Options

src/util/string.h

View Options

src/util/string.cpp

View Options

test/lint/lint-boost-dependencies.sh

refactor: Drop boost/algorithm/string/replace.hpp dependencyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40565

src/test/util_tests.cpp

src/util/string.h

src/util/string.cpp

test/lint/lint-boost-dependencies.sh

refactor: Drop boost/algorithm/string/replace.hpp dependency
ClosedPublic
Actions

Revision Contents
Changeset List