Fix a warning with GCC 13.1
ClosedPublic
Actions

Authored by Fabien on Jun 7 2023, 13:32.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC860df45214d4: Fix a warning with GCC 13.1

Summary

Fix another (see D14005) dropped return value.

There are still a couple more warnings but they seem to be false positives, so you need to build with -Wno-dangling-reference to see no warning at all with GCC 13.1.

Test Plan

With GCC 13.1

ninja all check-all

Check they throw no warning anymore.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 7 2023, 13:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2023, 13:32

Fabien requested review of this revision.Jun 7 2023, 13:32

Harbormaster completed remote builds in B23934: Diff 40638.Jun 7 2023, 13:55

PiRK accepted this revision.Jun 7 2023, 15:40

This revision is now accepted and ready to land.Jun 7 2023, 15:40

PiRK added inline comments.Jun 7 2023, 15:47

src/validation.cpp
1529 ↗	(On Diff #40638)	note that Core has a `Coin&& undo` here, but I cannot figure out when our codebases diverged. It must have been early after the BCH fork.