Page MenuHomePhabricator
Differential D14030

[ecash-herald] Parse memo txs using ecash-script library
ClosedPublic
Actions

Authored by bytesofman on Jun 9 2023, 16:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4d294d2f4e4e: [ecash-herald] Parse memo txs using ecash-script library
Summary

T2972

Parse all memo txs using ecash-script lib

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Jun 9 2023, 16:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2023, 16:26
bytesofman requested review of this revision.Jun 9 2023, 16:26
Harbormaster completed remote builds in B23972: Diff 40698.Jun 9 2023, 16:26
bytesofman updated this revision to Diff 40699.Jun 9 2023, 16:26

lint

Harbormaster completed remote builds in B23973: Diff 40699.Jun 9 2023, 16:28
bytesofman added inline comments.Jun 9 2023, 16:29
apps/ecash-herald/src/parse.js
471 ↗(On Diff #40699)

Removed here and done as the msg is composed for OP_RETURN txs

This allows including links or other HTML parsing for different pushes of complex OP_RETURN txs

Necessary for memo txs that include data where a block explorer link would be useful

bytesofman updated this revision to Diff 40700.Jun 9 2023, 16:30

typo fix

Harbormaster completed remote builds in B23974: Diff 40700.Jun 9 2023, 16:31
bytesofman mentioned this in D14031: [ecash-herald] Prep OP_RETURN strings for tg parsing depending on content.Jun 9 2023, 16:35
bytesofman added inline comments.Jun 9 2023, 17:10
apps/ecash-herald/src/parse.js
471 ↗(On Diff #40699)

See D14031 for this change in isolation

Fabien accepted this revision.Jun 9 2023, 18:27
This revision is now accepted and ready to land.Jun 9 2023, 18:27
bytesofman mentioned this in rABC041ae57f661f: [ecash-herald] Prep OP_RETURN strings for tg parsing depending on content.Jun 9 2023, 19:28
Closed by commit rABC4d294d2f4e4e: [ecash-herald] Parse memo txs using ecash-script library (authored by bytesofman). · Explain WhyJun 9 2023, 19:31
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC4d294d2f4e4e: [ecash-herald] Parse memo txs using ecash-script library.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
constants/
6 lines
src/
267 lines
test/
mocks/
135 lines
16 lines

Diff 40708

View Options

apps/ecash-herald/constants/op_return.js

Loading...
View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/test/mocks/blocks.js

Loading...
View Options

apps/ecash-herald/test/mocks/memo.js

Loading...
View Options

apps/ecash-herald/test/parseTests.js

Loading...