Differential D14032

Remove the miner fund consensus code
ClosedPublic
Actions

Authored by Fabien on Jun 9 2023, 16:45.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC43c402d947d7: Remove the miner fund consensus code

Summary

It is a block policy rule since wellington activated.

The code is changed so that it look like the consensus rules were never enforced as the past blocks are still valid. This also means we can remove the legacy IFP address related code.

Test Plan

ninja all check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 9 2023, 16:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2023, 16:45

@bot build-ibd

teamcity awarded a token.Jun 9 2023, 16:46

Harbormaster completed remote builds in B23976: Diff 40702.Jun 9 2023, 17:02

Improve the the block policy test

Harbormaster completed remote builds in B23988: Diff 40717.Jun 10 2023, 07:43

Fabien published this revision for review.Jun 10 2023, 19:22

PiRK accepted this revision.Jun 12 2023, 07:28

This revision is now accepted and ready to land.Jun 12 2023, 07:28

Closed by commit rABC43c402d947d7: Remove the miner fund consensus code (authored by Fabien). · Explain WhyJun 12 2023, 12:03

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC43c402d947d7: Remove the miner fund consensus code.

Revision Contents
Changeset List

Path

Size

src/

chainparams.cpp

9 lines

consensus/

4 lines

13 lines

2 lines

4 lines

25 lines

node/

miner.cpp

2 lines

policy/

block/

minerfund.cpp

4 lines

rpc/

mining.cpp

2 lines

test/

activation_tests.cpp

1 line

miner_tests.cpp

5 lines

minerfund_tests.cpp

19 lines

policy_block_tests.cpp

75 lines

validation.cpp

7 lines

test/

functional/

abc_feature_minerfund.py

24 lines

Diff 40732

View Options

src/chainparams.cpp

View Options

src/consensus/activation.h

View Options

src/consensus/activation.cpp

View Options

src/consensus/params.h

View Options

src/minerfund.h

View Options

src/minerfund.cpp

View Options

src/node/miner.cpp

View Options

src/policy/block/minerfund.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/activation_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/minerfund_tests.cpp

View Options

src/test/policy_block_tests.cpp

View Options

src/validation.cpp

View Options

test/functional/abc_feature_minerfund.py

Remove the miner fund consensus codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40732

src/chainparams.cpp

src/consensus/activation.h

src/consensus/activation.cpp

src/consensus/params.h

src/minerfund.h

src/minerfund.cpp

src/node/miner.cpp

src/policy/block/minerfund.cpp

src/rpc/mining.cpp

src/test/activation_tests.cpp

src/test/miner_tests.cpp

src/test/minerfund_tests.cpp

src/test/policy_block_tests.cpp

src/validation.cpp

test/functional/abc_feature_minerfund.py

Remove the miner fund consensus code
ClosedPublic
Actions

Revision Contents
Changeset List