Page MenuHomePhabricator

[e.cash] Center H2 image
ClosedPublic

Authored by johnkuney on Jun 15 2023, 19:45.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC6e0875a0e0ef: [e.cash] Center H2 image
Summary

Some instances of the H2 component will require a centered image. Adding an optional paramater to allow for that

Test Plan

npm run dev
scroll down to Roadmap section on the homepage and check the Header looks correct
To see the full effect of the change try changing the "roadmap" title to something longer, and then try removing the center
prop from the H2, you should see the line image go to the left

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-center-h2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24066
Build 47742: Build Diff
Build 47741: arc lint + arc unit

Event Timeline

bytesofman added a subscriber: bytesofman.
bytesofman added inline comments.
web/e.cash/components/h2/index.js
11

in this case, center will not be false if not provided, it will be undefined

modify the logic so that center will be false unless center is explicitly input as true

This revision now requires changes to proceed.Jun 15 2023, 19:50
This revision is now accepted and ready to land.Jun 15 2023, 21:54
This revision was automatically updated to reflect the committed changes.