Page MenuHomePhabricator

[e.cash] Add wallets page
ClosedPublic

Authored by johnkuney on Jun 19 2023, 22:57.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC50a67b8615a7: [e.cash] Add wallets page
Summary

Adding the base of the wallets page to the site. Will add the faqs at the bottom in another diff

Test Plan

Preview the site and navigate to /wallets page
inspect everything looks good and links work

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman added inline comments.
web/e.cash/data/wallets.js
19 ↗(On Diff #40881)

need to run npm run lint to catch things like these single quotes, should be replaced

web/e.cash/pages/wallets.js
21–45 ↗(On Diff #40881)

Does this need to be defined inside function Wallets() ?

I get that it is probably only being used here. But still kind of confusing.

Define above. Also, try to just pick one syntax for defining your functions. Confusing to have function Wallets() {} then immediately inside of that, const WalletCard = ({props}) => {}

This revision now requires changes to proceed.Jun 19 2023, 23:31

Okay added. I did npm run lint already, it didnt throw any errors for me though

This revision is now accepted and ready to land.Jun 20 2023, 18:30
This revision was automatically updated to reflect the committed changes.