Adding the base of the wallets page to the site. Will add the faqs at the bottom in another diff
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC50a67b8615a7: [e.cash] Add wallets page
Preview the site and navigate to /wallets page
inspect everything looks good and links work
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
web/e.cash/data/wallets.js | ||
---|---|---|
19 ↗ | (On Diff #40881) | need to run npm run lint to catch things like these single quotes, should be replaced |
web/e.cash/pages/wallets.js | ||
21–45 ↗ | (On Diff #40881) | Does this need to be defined inside function Wallets() ? I get that it is probably only being used here. But still kind of confusing. Define above. Also, try to just pick one syntax for defining your functions. Confusing to have function Wallets() {} then immediately inside of that, const WalletCard = ({props}) => {} |
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.63:41480 for the next 60 minutes.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41241 for the next 60 minutes.