As per title
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCf988153041e0: [electrum] add missing encodings to open() calls and enable linter
arc lint --everything cd electrum python -m electrumabc.tests
Build for windows and run from command line with arg -v (to test the winconsole encoding)
Try also wine dist/ElectrumABC-5.2.4.exe -v on linux.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Please keep the code consistent and choose between utf8 and utf-8, but don't randomly use one or the other
| electrum/electrumabc/blockchain.py | ||
|---|---|---|
| 317 ↗ | (On Diff #40955) | Most of the changes here are unrelated to the diff, and are very debatable. Please don't mix in refactors like this |
| electrum/electrumabc/blockchain.py | ||
|---|---|---|
| 317 ↗ | (On Diff #40955) | OK, I will revert this. My problem with the existing code is that open(self.path(), "wb").close() is very misleading and didn't make sense to me at first glance, until I understood that self is not what I expected it to be and that we actually create a new file. |