Differential D14137

[e.cash] Naming tweak for fetch blog function
ClosedPublic
Actions

Authored by johnkuney on Jun 27 2023, 17:24.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC51ceb98f814d: [e.cash] Naming tweak for fetch blog function

Summary

Im working on the blog page and realized the return value of the getBlogPosts function could be named better, 'posts'
makes more sense than 'responses' to me. Also realized the propsObj props value needs to be an object to work with getStaticProps

Test Plan

npm run test should still pass

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-blogs-edit

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24208
Build 48026: Build Diff
Build 48025: arc lint + arc unit

Event Timeline

johnkuney created this revision.Jun 27 2023, 17:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2023, 17:24

johnkuney requested review of this revision.Jun 27 2023, 17:24

Harbormaster completed remote builds in B24207: Diff 41036.Jun 27 2023, 17:24

update test

Harbormaster completed remote builds in B24208: Diff 41037.Jun 27 2023, 17:24

Fabien accepted this revision.Jun 27 2023, 18:18

This revision is now accepted and ready to land.Jun 27 2023, 18:18

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41391 for the next 60 minutes.

Closed by commit rABC51ceb98f814d: [e.cash] Naming tweak for fetch blog function (authored by johnkuney). · Explain WhyJun 27 2023, 19:22

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC51ceb98f814d: [e.cash] Naming tweak for fetch blog function.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

data/

__tests__/

blog.test.js

8 lines

blog.js

6 lines

Diff 41037

View Options

web/e.cash/data/tests/blog.test.js

View Options

[e.cash] Naming tweak for fetch blog functionClosedPublicActions