nit for all of these: you don't need to include .js here

nit depending on your IDE

in VS code, you can just type /** and push enter, it will auto generate code comments including the params of your function if you type this above a defined function, e.g. doing so for this function would give

/**
 *  
 * @returns
 */

which you could then fill in. If you have params, it would include those.
This also provides a unique comment format for functions (which is something of a standard across JS, in that I've seen it some places and VS code supports it, although it's certainly not universal) as opposed to general comments.

Not a blocker but imo it's a timesaver and nice to have for the JS apps in the monorepo, should converge on this as a standard.

Should include some comments here as we are writing these scripts as examples for developers. Discussion of how english is typically the recommended default but it is possible to use various languages, ref bip39 documentation

tough var name but we should definitely avoid stringing numbers together like this.

In this case, I think it's ok to just call it mnemonic, as the comment explains exactly what kind of mnemonic it is

Useful coment would be to say that seed and mnemonic are often used interchangeably. We're talking about a human-readable private key backup here.

hm there is a ton of stuff we could say about this. We should probably just link to some documentation about HD wallets and derivation paths, e.g. https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki

Need some discussion about this one. minimum, "For eCash wallets, Path 1899 is used for a wallet that supports eTokens. Path 899 is used for a wallet that does not support eTokens."

Some comments about the available types would be useful, e.g. "p2pkh - standard for most wallets; p2sh - multisig or other advanced features"

latest version of ecashaddrjs accepts lowercase address type input. worth using imo since chronik-client always accepts lowercase address type input

Need up upgrade ecashaddrjs to 1.5.2 for this support, npm i ecashaddrjs@latest

Since there are no expected error conditions, just do one test that checks everything, i.e.

• keep assert.strictEqual(isValidAddress, true); and assert.strictEqual(isValidMnemonic, true);
• Confirm that Object.keys(wallet) contains address, publicKey, mnemonic, derivationPath
• Also confirm derivation path is 1899.