Paths

Table of Contentst

Differential D14173

[ecash-herald] Patch import error for secrets
ClosedPublic
Actions

Authored by bytesofman on Jun 30 2023, 17:47.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCca1eb76e3fd2: [ecash-herald] Patch import error for secrets

Summary

T2972

This is an artifact from when the app was being developed and put into production locally. secrets.js should be in the top level like config, not above the top level.

Test Plan

node index.js and no errors (if you have secrets.js with telegram bot info). Otherwise, confirm README specifies secrets.js should go in same dir as config.js

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jun 30 2023, 17:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2023, 17:47

bytesofman requested review of this revision.Jun 30 2023, 17:47

Harbormaster completed remote builds in B24271: Diff 41134.Jun 30 2023, 17:48

README update

Harbormaster completed remote builds in B24272: Diff 41135.Jun 30 2023, 17:50

PiRK accepted this revision.Jul 1 2023, 05:58

This revision is now accepted and ready to land.Jul 1 2023, 05:58

Closed by commit rABCca1eb76e3fd2: [ecash-herald] Patch import error for secrets (authored by bytesofman). · Explain WhyJul 1 2023, 21:00

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCca1eb76e3fd2: [ecash-herald] Patch import error for secrets.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

11 lines

2 lines

Diff 41161

apps/ecash-herald/README.md

Loading...

apps/ecash-herald/index.js

Loading...