Differential D14182

[Apps][Examples] Remove chronik url input arg from getTxHistoryFromAddress
ClosedPublic
Actions

Authored by emack on Jul 1 2023, 08:37.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC9ebe6d0e8f93: [Apps][Examples] Remove chronik url input arg from getTxHistoryFromAddress

Summary

As per feedback from D14166, removing the chronik url input arg

Test Plan

npm test
npm run getTxHistoryFromAddress <address> <page> <pageSize>

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Jul 1 2023, 08:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2023, 08:37

emack requested review of this revision.Jul 1 2023, 08:37

Harbormaster completed remote builds in B24291: Diff 41156.Jul 1 2023, 08:39

bytesofman requested changes to this revision.Jul 1 2023, 21:14

bytesofman added inline comments.

apps/examples/scripts/getTxHistoryFromAddress.js
49 ↗	(On Diff #41156)	this URL is common to several scripts and should be imported from a config file

This revision now requires changes to proceed.Jul 1 2023, 21:14

emack requested review of this revision.Jul 1 2023, 22:57

emack added inline comments.

apps/examples/scripts/getTxHistoryFromAddress.js
49 ↗	(On Diff #41156)	As discussed

bytesofman accepted this revision.Jul 2 2023, 03:16

This revision is now accepted and ready to land.Jul 2 2023, 03:16

Closed by commit rABC9ebe6d0e8f93: [Apps][Examples] Remove chronik url input arg from getTxHistoryFromAddress (authored by emack). · Explain WhyJul 2 2023, 03:22

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC9ebe6d0e8f93: [Apps][Examples] Remove chronik url input arg from getTxHistoryFromAddress.

Revision Contents
Changeset List

Path

Size

apps/

examples/

README.md

4 lines

scripts/

getTxHistoryFromAddress.js

9 lines

Diff 41175

View Options

apps/examples/README.md