Page MenuHomePhabricator

[alias-server] Error response handling patch
ClosedPublic

Authored by emack on Jul 2 2023, 09:02.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC366a96823508: [alias-server] Error response handling patch
Summary

As observed in D14191, when Cashtab feeds through invalid inputs to the alias-server endpoints, its fetch() calls are returning undefined rather than the expected error object.
Upon review the address and alias endpoints in alias-server's app.js were correctly catching the errors but weren't returning the status 500 error.

Test Plan

npm test
propagate diff to alias.etokens.cash
retest Cashtab fetch calls in D14191 and D14189

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable