Footer needs some width adjusment on medium screens
-moved blog link under about to avoid single item column
-added large breakpoint to theme
-modify css to accomodate footer on medium screens
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC4ce546119106: [e.cash] Fix footer issues
preview the site and check the footer looks good and doesnt cause horizontal overflow
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-fix-footer
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 24436 Build 48472: Build Diff Build 48471: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41757 for the next 60 minutes.
| web/e.cash/components/footer/index.js | ||
|---|---|---|
| 70 ↗ | (On Diff #41325) | seems kind of hacky to be manually calling out specific links here. goal is to get blog into the about category -- why can't this be done the same way other links are in other categories? |
Comment Actions
sure fair enough, can do it by putting all nav items without dropdown items in a certain index. This avoids any specific nav callouts
| web/e.cash/components/footer/index.js | ||
|---|---|---|
| 74 ↗ | (On Diff #41352) | It's conceivable that {index} could be used as a key somewhere else on the page. Replace with key={${navitem}_${index}} |
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41317 for the next 60 minutes.