Page MenuHomePhabricator
Differential D14264

[e.cash] Add image priority
ClosedPublic
Actions

Authored by johnkuney on Jul 12 2023, 22:54.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCb422db55b319: [e.cash] Add image priority
Summary

I noticed some top level images weren't loading first on some pages. Added the priority attribute from next.js
to a few places to help prevent this

Test Plan

preview the site and check the updated places
you may be able to decern an improvemnt in image priority

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-image-priority
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24479
Build 48558: Build Diff
Build 48557: arc lint + arc unit

Event Timeline

johnkuney created this revision.Jul 12 2023, 22:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2023, 22:54
johnkuney requested review of this revision.Jul 12 2023, 22:54
Harbormaster completed remote builds in B24479: Diff 41429.Jul 12 2023, 22:54
bytesofman added a subscriber: bytesofman.Jul 13 2023, 03:42

@bot preview-e.cash

teamcity awarded a token.Jul 13 2023, 03:42
teamcity added a comment.Jul 13 2023, 03:52

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.89.41.69:41306 for the next 60 minutes.

bytesofman added a comment.Jul 13 2023, 13:03

@bot preview-e.cash

teamcity updated a token.Jul 13 2023, 13:03

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41631 for the next 60 minutes.

bytesofman added a comment.Jul 13 2023, 13:04

ref https://nextjs.org/docs/pages/api-reference/components/image#priority

bytesofman accepted this revision.Jul 13 2023, 13:05

seems like the right idea + proper usage, build and load time look good

This revision is now accepted and ready to land.Jul 13 2023, 13:05
Closed by commit rABCb422db55b319: [e.cash] Add image priority (authored by johnkuney). · Explain WhyJul 13 2023, 15:51
This revision was automatically updated to reflect the committed changes.
johnkuney added a commit: rABCb422db55b319: [e.cash] Add image priority.

Revision Contents
Changeset List

PathSize
web/
e.cash/
components/
navbar/
1 line
pages/
1 line
blog/
1 line
2 lines

Diff 41429

View Options

web/e.cash/components/navbar/index.js

Loading...
View Options

web/e.cash/pages/blog.js

Loading...
View Options

web/e.cash/pages/blog/[slug].js

Loading...
View Options

web/e.cash/pages/index.js

Loading...