Paths

Table of Contentst

Differential D14273

[electrum] always test the latest Bitcoin ABC and fulcrum in functional tests
ClosedPublic
Actions

Authored by PiRK on Jul 17 2023, 08:43.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC041269e6f4d1: [electrum] always test the latest Bitcoin ABC and fulcrum in functional tests

Summary

This way we will know sooner if fulcrum and Bitcoin ABC become incompatible.

And fix CONTRIBUTING.md

Test Plan

Check that the latest tag matches the most recent docker for both Bitcoin ABC and fulcrum

pip3 install -r contrib/requirements/requirements-regtest.txt
pytest electrumabc/tests/regtest`

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 17 2023, 08:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2023, 08:43

PiRK requested review of this revision.Jul 17 2023, 08:43

Ideally we should test the current master branch for Bitcoin ABC, but that requires some integration between electrum and Bitcoin ABC's functional tests.

Harbormaster completed remote builds in B24508: Diff 41462.Jul 17 2023, 08:50

Fabien accepted this revision.Jul 17 2023, 08:58

This revision is now accepted and ready to land.Jul 17 2023, 08:58

Closed by commit rABC041269e6f4d1: [electrum] always test the latest Bitcoin ABC and fulcrum in functional tests (authored by PiRK). · Explain WhyJul 17 2023, 09:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC041269e6f4d1: [electrum] always test the latest Bitcoin ABC and fulcrum in functional tests.

Revision Contents
Changeset List

Path

Size

electrum/

CONTRIBUTING.md

10 lines

electrumabc/

tests/

regtest/

docker-compose.yml

4 lines

Diff 41463

View Options

electrum/CONTRIBUTING.md