[e.cash] Add anchor links to sections
ClosedPublic
Actions

Authored by johnkuney on Jul 20 2023, 19:55.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC5365cded0377: [e.cash] Add anchor links to sections

Summary

as per https://reviews.bitcoinabc.org/T3241 adding some ids to be used for anchor links in some places

Test Plan

preview the site and test out the links, for example
/ecash-brand#logos
/ecash-brand#colors
/ecash-brand#fonts
/faq#1 - /faq#15
/wealth-redefined#wealth-redefined
/wealth-redefined#our-why
/wealth-redefined#our-inspiration
/wealth-redefined#project-development
/#roadmap

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

johnkuney created this revision.Jul 20 2023, 19:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2023, 19:55

johnkuney requested review of this revision.Jul 20 2023, 19:55

Harbormaster completed remote builds in B24563: Diff 41541.Jul 20 2023, 19:55

johnkuney edited the test plan for this revision. (Show Details)Jul 20 2023, 19:56

johnkuney edited the test plan for this revision. (Show Details)Jul 20 2023, 19:58

johnkuney edited the test plan for this revision. (Show Details)

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41097 for the next 60 minutes.

hm the first time I tried /ecash-brand#fonts, it loaded to Montserrat instead of ecash official fonts glitch text; same with faq#1 ... but now I can't repeat it. Mb it can happen when page is not fully loaded, mb browser issue. Imo no blocker since it's not related to the anchor being misplaced, but something to keep an eye out for.

This revision is now accepted and ready to land.Jul 21 2023, 20:44

Closed by commit rABC5365cded0377: [e.cash] Add anchor links to sections (authored by johnkuney). · Explain WhyJul 24 2023, 14:31

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC5365cded0377: [e.cash] Add anchor links to sections.