Differential D14303

[e.cash] Add social card image
ClosedPublic
Actions

Authored by johnkuney on Jul 24 2023, 21:15.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC7a7b0b23a62d: [e.cash] Add social card image

Summary

Adding the social card image back in

Test Plan

Social cards only work on the prod site and require an absolute path for the image. So not a great way to test.
But can preview the site and check the code is in the head as expected

Once live we can run a validator to see if the image is coming through

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-twitter-card

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24582
Build 48761: Build Diff
Build 48760: arc lint + arc unit

Event Timeline

johnkuney created this revision.Jul 24 2023, 21:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2023, 21:15

johnkuney requested review of this revision.Jul 24 2023, 21:15

Harbormaster completed remote builds in B24582: Diff 41572.Jul 24 2023, 21:15

johnkuney edited the test plan for this revision. (Show Details)Jul 24 2023, 21:16

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.62:41370 for the next 60 minutes.

bytesofman accepted this revision.Jul 24 2023, 21:23

This revision is now accepted and ready to land.Jul 24 2023, 21:23

Closed by commit rABC7a7b0b23a62d: [e.cash] Add social card image (authored by johnkuney). · Explain WhyJul 25 2023, 02:14

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC7a7b0b23a62d: [e.cash] Add social card image.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

components/

layout/

index.js

4 lines

public/

images/

ecash-twitter-card.jpg

Diff 41572

View Options

web/e.cash/components/layout/index.js