Paths

Table of Contentst

Differential D14309

[avalanche] Fix the finalized proof count being wrong when pending nodes reconnect
ClosedPublic
Actions

Authored by Fabien on Jul 25 2023, 13:10.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1613d64ff7df: [avalanche] Fix the finalized proof count being wrong when pending nodes…

Summary

If a finalized proof is discarded due to missing nodes, and a node later reconnects, the proof is not polled again as expected but the finalization flag is not set properly on the peer. This diff fixes the count and add a test case that reproduces the issue. Note that only the RPC output is affected by this change.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 25 2023, 13:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2023, 13:10

Fabien requested review of this revision.Jul 25 2023, 13:10

Harbormaster completed remote builds in B24592: Diff 41585.Jul 25 2023, 13:25

PiRK accepted this revision.Jul 25 2023, 13:40

PiRK added a subscriber: PiRK.

PiRK added inline comments.

src/net_processing.cpp
7242 ↗	(On Diff #41585)
test/functional/abc_rpc_getavalancheinfo.py
601 ↗	(On Diff #41585)	`Decimal("0.00")` for consistency with the other fields

This revision is now accepted and ready to land.Jul 25 2023, 13:40

Closed by commit rABC1613d64ff7df: [avalanche] Fix the finalized proof count being wrong when pending nodes… (authored by Fabien). · Explain WhyJul 25 2023, 13:44

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1613d64ff7df: [avalanche] Fix the finalized proof count being wrong when pending nodes….

Fabien mentioned this in D14311: Fix a possible message ordering issue in abc_rpc_getavalancheinfo.Jul 26 2023, 09:44

Fabien mentioned this in rABCff0d18517724: Fix a possible message ordering issue in abc_rpc_getavalancheinfo.Jul 26 2023, 15:01

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

4 lines

src/

avalanche/

1 line

8 lines

net_processing.cpp

10 lines

test/

functional/

abc_rpc_getavalancheinfo.py

80 lines

Diff 41586

doc/release-notes.md

Loading...

src/avalanche/processor.h

Loading...

src/avalanche/processor.cpp

Loading...

src/net_processing.cpp

Loading...

test/functional/abc_rpc_getavalancheinfo.py

Loading...