Page MenuHomePhabricator

[Cashtab] Move settings validation and supported fiat currency list out of Ticker.js and to settings
ClosedPublic

Authored by bytesofman on Aug 10 2023, 19:41.

Details

Summary

T3261

It makes sense for cashtabSettingsValidation to live with cashtabSettings in config/cashtabSettings.js

Also makes since for list of supported fiat currencies to live here, as this is a settings option.

Test Plan

npm test
grep -r fiatCurrencies src/ and no output
grep -r settingsValidation src/ and no output

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/config/cashtabSettings.js
52 ↗(On Diff #41772)

I get the idea but it's not really elegant, it duplicates the data and the [true, false] for the boolean is boilerplate. Can be refactored later.

This revision is now accepted and ready to land.Aug 11 2023, 06:53