Page MenuHomePhabricator
Differential D14387

build: Drop unneeded ApplicationServices framework dependency
ClosedPublic
Actions

Authored by PiRK on Aug 21 2023, 06:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb8ca9a127777: build: Drop unneeded ApplicationServices framework dependency
Summary

This is a backport of core#20496

Test Plan

ninja all check-all

gitian-osx

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 21 2023, 06:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 21 2023, 06:43
teamcity edited the summary of this revision. (Show Details)Aug 21 2023, 06:43
PiRK added a comment.Aug 21 2023, 06:43

@bot build-osx gitian-osx

teamcity awarded a token.Aug 21 2023, 06:43
Harbormaster completed remote builds in B24796: Diff 41862.Aug 21 2023, 06:55
teamcity added a comment.Aug 21 2023, 06:55
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

wallet_watchonly.py                       | ✓ Passed  | 1 s
wallet_watchonly.py --usecli              | ✓ Passed  | 2 s
chronik_avalanche.py                      | ○ Skipped | 0 s
chronik_block.py                          | ○ Skipped | 0 s
chronik_block_info.py                     | ○ Skipped | 0 s
chronik_block_txs.py                      | ○ Skipped | 0 s
chronik_blockchain_info.py                | ○ Skipped | 0 s
chronik_blocks.py                         | ○ Skipped | 0 s
chronik_disallow_prune.py                 | ○ Skipped | 0 s
chronik_pause.py                          | ○ Skipped | 0 s
chronik_raw_tx.py                         | ○ Skipped | 0 s
chronik_resync.py                         | ○ Skipped | 0 s
chronik_script_confirmed_txs.py           | ○ Skipped | 0 s
chronik_script_history.py                 | ○ Skipped | 0 s
chronik_script_unconfirmed_txs.py         | ○ Skipped | 0 s
chronik_script_utxos.py                   | ○ Skipped | 0 s
chronik_serve.py                          | ○ Skipped | 0 s
chronik_spent_by.py                       | ○ Skipped | 0 s
chronik_tx.py                             | ○ Skipped | 0 s
chronik_ws.py                             | ○ Skipped | 0 s
chronik_ws_script.py                      | ○ Skipped | 0 s
interface_usdt_net.py                     | ○ Skipped | 0 s
interface_usdt_utxocache.py               | ○ Skipped | 0 s
interface_usdt_validation.py              | ○ Skipped | 0 s

ALL                                       | ✓ Passed  | 1927 s (accumulated) 
Runtime: 386 s

[362/487] bitcoin: testing validationinterface_tests
FAILED: src/test/CMakeFiles/check-bitcoin-validationinterface_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-validationinterface_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=validationinterface_tests --logger=HRF,message:JUNIT,message,bitcoin-validationinterface_tests.xml --catch_system_errors=no
Running 3 test cases...
../../src/test/validationinterface_tests.cpp(108): error: in "validationinterface_tests/unregister_all_during_call": check destroyed has failed

*** 1 failure is detected in the test module "Bitcoin ABC unit tests"
[386/487] Running secp256k1 test suite
PASSED: secp256k1 test suite
[440/487] Running avalanche test suite
PASSED: avalanche test suite
[453/487] Running seeder test suite
PASSED: seeder test suite
[456/487] Running pow test suite
PASSED: pow test suite
[459/487] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.020s

OK
[460/487] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[478/487] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[484/487] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Aug 21 2023, 07:07
Build Bitcoin ABC Diffs / Diff Testing (gitian-osx) failed.

Tail of the build log:

 * [new tag]             phabricator/diff/41539 -> phabricator/diff/41539
 * [new tag]             phabricator/diff/41571 -> phabricator/diff/41571
 * [new tag]             phabricator/diff/41573 -> phabricator/diff/41573
 * [new tag]             phabricator/diff/41574 -> phabricator/diff/41574
 * [new tag]             phabricator/diff/41575 -> phabricator/diff/41575
 * [new tag]             phabricator/diff/41579 -> phabricator/diff/41579
 * [new tag]             phabricator/diff/41582 -> phabricator/diff/41582
 * [new tag]             phabricator/diff/41594 -> phabricator/diff/41594
 * [new tag]             phabricator/diff/41596 -> phabricator/diff/41596
 * [new tag]             phabricator/diff/41603 -> phabricator/diff/41603
 * [new tag]             phabricator/diff/41604 -> phabricator/diff/41604
 * [new tag]             phabricator/diff/41605 -> phabricator/diff/41605
 * [new tag]             phabricator/diff/41617 -> phabricator/diff/41617
 * [new tag]             phabricator/diff/41695 -> phabricator/diff/41695
 * [new tag]             phabricator/diff/41753 -> phabricator/diff/41753
 * [new tag]             phabricator/diff/41754 -> phabricator/diff/41754
 * [new tag]             phabricator/diff/41755 -> phabricator/diff/41755
 * [new tag]             phabricator/diff/41783 -> phabricator/diff/41783
 * [new tag]             phabricator/diff/41784 -> phabricator/diff/41784
 * [new tag]             phabricator/diff/41786 -> phabricator/diff/41786
 * [new tag]             phabricator/diff/41787 -> phabricator/diff/41787
 * [new tag]             phabricator/diff/41788 -> phabricator/diff/41788
 * [new tag]             phabricator/diff/41790 -> phabricator/diff/41790
 * [new tag]             phabricator/diff/41791 -> phabricator/diff/41791
 * [new tag]             phabricator/diff/41793 -> phabricator/diff/41793
 * [new tag]             phabricator/diff/41795 -> phabricator/diff/41795
 * [new tag]             phabricator/diff/41829 -> phabricator/diff/41829
 * [new tag]             phabricator/diff/41836 -> phabricator/diff/41836
 * [new tag]             phabricator/diff/41845 -> phabricator/diff/41845
 * [new tag]             phabricator/diff/41846 -> phabricator/diff/41846
 * [new tag]             phabricator/diff/41847 -> phabricator/diff/41847
 * [new tag]             phabricator/diff/41848 -> phabricator/diff/41848
 * [new tag]             phabricator/diff/41849 -> phabricator/diff/41849
 * [new tag]             phabricator/diff/41853 -> phabricator/diff/41853
 * [new tag]             phabricator/diff/41862 -> phabricator/diff/41862
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1
PiRK updated this revision to Diff 41865.Aug 21 2023, 07:34

revert changes to symbol-check (these libs are probably still included by the SDK)

PiRK added a comment.Aug 21 2023, 07:34

@bot gitian-osx

teamcity updated a token.Aug 21 2023, 07:34
Harbormaster completed remote builds in B24798: Diff 41865.Aug 21 2023, 07:55
PiRK published this revision for review.Aug 21 2023, 08:24
PiRK mentioned this in D14389: test: Avoid intermittent issues due to async events in validationinterface_tests.Aug 21 2023, 08:25
Fabien accepted this revision.Aug 21 2023, 09:10
This revision is now accepted and ready to land.Aug 21 2023, 09:10
Closed by commit rABCb8ca9a127777: build: Drop unneeded ApplicationServices framework dependency (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyAug 21 2023, 10:06
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb8ca9a127777: build: Drop unneeded ApplicationServices framework dependency.

Revision Contents
Changeset List

PathSize
src/
qt/
1 line
5 lines

Diff 41868

View Options

src/qt/CMakeLists.txt

Loading...
View Options

src/qt/notificator.cpp

Loading...