The address info on token send txs is not really useful and can be found by investigating the txid. Remove this info so token send msgs simply provide amount and token ticker.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABCa1699180470e: [ecash-herald] Tighter token send descriptions
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
apps/ecash-herald/src/parse.js | ||
---|---|---|
1390–1405 ↗ | (On Diff #42013) | This else block is now exactly the same code as the previous block, except for a local variable name and the input data (tokenReceivingOutputs vs tokenChangeOutputs) It could be refactored to deduplicate the common code out out the branching, and just keep the branching to assign the input data let tokenOutputs = tokenReceivingOutputs; // Parse token self-send txs if (tokenReceivingOutputs.size === 0) { tokenOutputs = tokenChangeOutputs; } |