[electrum] fix NameError in keepkey.py
ClosedPublic
Actions

Authored by PiRK on Sep 12 2023, 06:42.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCdf16c5090894: [electrum] fix NameError in keepkey.py

Summary

While trying to run pytest, I noticed this error. It is caused by Transaction being used in a typehint while not actually being imported. Enable postponed evaluation of annotations to fix this.

NameError: name 'Transaction' is not defined

Test Plan

python -m electrumabc_plugins.keepkey.keepkey

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 12 2023, 06:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2023, 06:42

PiRK requested review of this revision.Sep 12 2023, 06:42

Harbormaster completed remote builds in B24999: Diff 42146.Sep 12 2023, 06:44

Fabien accepted this revision.Sep 12 2023, 07:10

This revision is now accepted and ready to land.Sep 12 2023, 07:10

Closed by commit rABCdf16c5090894: [electrum] fix NameError in keepkey.py (authored by PiRK). · Explain WhySep 12 2023, 07:24

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCdf16c5090894: [electrum] fix NameError in keepkey.py.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_plugins/

keepkey/

keepkey.py

2 lines

Diff 42150

View Options

electrum/electrumabc_plugins/keepkey/keepkey.py

[electrum] fix NameError in keepkey.pyClosedPublicActions