Implement support for AED fiat. Coingecko supports so this is a straightforward add.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC23089449df42: [Cashtab] Support UAE Dirham currency
npm test, npm start and switch to the currency in settings, check that amount is in line with FOREX rate
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Accepted with minor nit
| cashtab/src/config/cashtabSettings.js | ||
|---|---|---|
| 19 ↗ | (On Diff #42353) | Symbol should be د.إ to be consistent with the yuan, yen...etc |
| cashtab/src/config/cashtabSettings.js | ||
|---|---|---|
| 19 ↗ | (On Diff #42353) | Good point -- gave this a try. However the arabic alphabet is right-to-left, which causes this symbol to appear on the right side of the balance number (which still reads left to right in Cashtab). I tried looking up some examples of how this would usually appear in the UAE but didn't immediately find an answer I was confident with. So, I'm not sure if this placement would be correct or confusing. So -- let's use the latin one here to start since it is at least a known convention and does not require special handling for right-to-left issue. If we get an ask for changing it, can work it out. |