fix confusing parameter information
AbandonedPublic
Actions

Authored by jasonbcox on May 25 2018, 02:30.

Details

Reviewers

deadalnix
qshuai

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

getaddednodeinfo rpc command requires only on parameter<optional>. But the help information declares that it works with two parameter<additional bool parameter>.

Test Plan

Have tested on my bitcoin-abc node

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2642
Build 3398: Bitcoin ABC Buildbot (legacy)
Build 3397: arc lint + arc unit

Event Timeline

qshuai created this revision.May 25 2018, 02:30

Owners added a reviewer: Restricted Owners Package.May 25 2018, 02:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2018, 02:30

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2642: Diff 3976!May 25 2018, 02:31

Please use clang-format 4.0 to format the code. Except that it's all good.

deadalnix requested changes to this revision.May 27 2018, 17:44

This revision now requires changes to proceed.May 27 2018, 17:44

Duplicate of: https://reviews.bitcoinabc.org/D1447

Revision Contents
Changeset List

Path

Size

src/

rpc/

net.cpp

60 lines

Diff 3976

View Options

fix confusing parameter informationAbandonedPublicActions