[Cashtab] Better UI for param sends
ClosedPublic
Actions

Authored by bytesofman on Sep 26 2023, 19:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC72549cbf5b3f: [Cashtab] Better UI for param sends

Summary

Now that PayButton is active in the wild, it's a more common user experience to scan a QR code with params.

Stop showing a confusing alert about how only the amount param is supported
Make sure that a confirmation modal comes up for any tx created by params, regardless of user setting

Test Plan

npm test

npm start, go to Send screen, copy paste a valid param string i.e. ecash:qplkmuz3rx480u6vc4xgc0qxnza42p0e7vll6p90wr?amount=516.55, verify no alert, verify on "send" you get a confirmation modal

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 26 2023, 19:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2023, 19:12

bytesofman requested review of this revision.Sep 26 2023, 19:12

Harbormaster completed remote builds in B25175: Diff 42406.Sep 26 2023, 19:15

Fabien requested changes to this revision.Sep 27 2023, 08:50

Fabien added a subscriber: Fabien.

Fabien added inline comments.

cashtab/src/components/Send/Send.js
970 ↗	(On Diff #42406)	There is a discrepancy between this sentence and your test plan. Which one is correct ? Is the amount in satoshis or XEC ? You don't want to accidentally send x100 the amount

This revision now requires changes to proceed.Sep 27 2023, 08:50

bytesofman requested review of this revision.Sep 27 2023, 13:03

bytesofman added inline comments.

cashtab/src/components/Send/Send.js
970 ↗	(On Diff #42406)	XEC is correct. In addition to this warning being confusing, it's also incorrect. This diff also forces the "are you sure you want to send (this amount) XEC to (this address)?" modal for txs created by scanning these param-including addresses, since in theory anyone could make a qr code that populates a tx that sends a bunch of eCash to any given wallet.