Page MenuHomePhabricator
Differential D14558

Revert "[avalanche] Use SteadyMilliseconds where possible"
AbandonedPublic
Actions

Authored by Fabien on Sep 28 2023, 20:11.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

This reverts commit rABC9e068b92c3af64a4a131b3479354b2989ff5134f.

This is causing a test failure that I don't understand and didn't manage to reproduce on purpose (it happened randomly twice on my machine after >3000 runs).
This this was intended to be only a cosmetic change and it turns out to be do more than expected, let's revert to avoid introducing some subtle bug.

Test Plan
ninja check-avalanche

Diff Detail

Event Timeline

Fabien created this revision.Sep 28 2023, 20:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2023, 20:11
Fabien requested review of this revision.Sep 28 2023, 20:11
Fabien added a comment.Sep 28 2023, 20:12

The failure: https://build.bitcoinabc.org/viewLog.html?buildId=618848&buildTypeId=BitcoinABC_Master_BuildWithoutQt&tab=buildChangesDiv&guest=1

teamcity added a comment.Sep 28 2023, 20:12
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Harbormaster completed remote builds in B25206: Diff 42444.Sep 28 2023, 20:12
teamcity added a comment.Sep 28 2023, 20:12
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman accepted this revision.Sep 28 2023, 22:55
This revision is now accepted and ready to land.Sep 28 2023, 22:55
Fabien planned changes to this revision.Sep 29 2023, 09:53

I think I finally figured it out

Fabien mentioned this in D14562: [avalanche] Remove TimePoint in favor of SteadyMilliseconds.Sep 29 2023, 12:30
Fabien mentioned this in rABC165e87dacdb8: [avalanche] Remove TimePoint in favor of SteadyMilliseconds.Sep 29 2023, 13:21
Fabien abandoned this revision.Sep 29 2023, 18:36

Revision Contents
Changeset List

PathSize
src/
avalanche/
6 lines
5 lines
5 lines
test/
20 lines
3 lines
2 lines
util/
2 lines

Diff 42444

View Options

src/avalanche/node.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/util/time.h

Loading...