Differential D14591

[qt] Remove assignment in if statement
ClosedPublic
Actions

Authored by Fabien on Oct 4 2023, 08:40.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC60349c31247a: [qt] Remove assignment in if statement

Summary

This serves 2 purposes:

It is much more readable
It works around a discrepancy between clang-format 12.0.0 and 12.0.1

There is no change in behavior.

Test Plan

ninja check-bitcoin-qt

Send a tx to check the modals work as intended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 4 2023, 08:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2023, 08:40

Fabien requested review of this revision.Oct 4 2023, 08:40

Harbormaster completed remote builds in B25254: Diff 42523.Oct 4 2023, 08:54

Fabien edited the test plan for this revision. (Show Details)Oct 4 2023, 09:23

PiRK accepted this revision.Oct 4 2023, 09:26

This revision is now accepted and ready to land.Oct 4 2023, 09:26

Closed by commit rABC60349c31247a: [qt] Remove assignment in if statement (authored by Fabien). · Explain WhyOct 4 2023, 09:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC60349c31247a: [qt] Remove assignment in if statement.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.cpp

6 lines

Diff 42525

View Options

[qt] Remove assignment in if statementClosedPublicActions