Differential D14602

[electrum] minor improvements to proof editor
ClosedPublic
Actions

Authored by PiRK on Oct 5 2023, 06:30.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd1649bc29290: [electrum] minor improvements to proof editor

Summary

Add a "copy to clipboard" button to Master key fields.
Make it visually clear that the master pubkey is not editable (on some systems setReadOnly does not modify the style)
Improve tooltips
Improve labels

Test Plan

open the proof editor in any wallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 5 2023, 06:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2023, 06:30

PiRK requested review of this revision.Oct 5 2023, 06:30

Harbormaster completed remote builds in B25275: Diff 42561.Oct 5 2023, 06:31

Fabien added a subscriber: Fabien.Oct 5 2023, 07:48

Fabien added inline comments.

electrum/electrumabc_gui/qt/avalanche/proof_editor.py
268 ↗	(On Diff #42561)	Can we make it unconditionally super duper clear that it's not the coins key? Suggestion: This key is avalanche specific, unrelated to your coins and cannot be used to spend them. DO NOT USE any existing private key!

make the tooltip more clear and unconditional

Harbormaster completed remote builds in B25276: Diff 42562.Oct 5 2023, 09:03

clarify ++

Fabien accepted this revision.Oct 5 2023, 09:38

This revision is now accepted and ready to land.Oct 5 2023, 09:38

Harbormaster completed remote builds in B25277: Diff 42564.Oct 5 2023, 09:42

Closed by commit rABCd1649bc29290: [electrum] minor improvements to proof editor (authored by PiRK). · Explain WhyOct 5 2023, 11:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd1649bc29290: [electrum] minor improvements to proof editor.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_gui/

qt/

avalanche/

proof_editor.py

38 lines

Diff 42569

electrum/electrumabc_gui/qt/avalanche/proof_editor.py

Loading...